ci: run a11y tests in their own CI job, separate from e2e - #197
Open
antfubot wants to merge 3 commits into
Open
Conversation
`pnpm test:e2e` used to run every Playwright project, including the axe-core color-contrast scans (`a11y` project) inside the single `e2e` CI job. Split them: - `test:e2e` now targets the five e2e-only projects explicitly (dev, build, webcontainer, instant, build-subbase). - New `test:a11y` script runs just the `a11y` project. - CI gets a new `a11y` job mirroring `e2e`'s Playwright setup, so a11y regressions surface as their own check and run in parallel with e2e instead of extending its runtime. Created with the help of an agent.
…t.ts Pre-existing lint failure from antfu#195 — some object-literal keys were quoted (`'h3'`) while sibling keys of the same object weren't (`nuxt`), which `style/quote-props` flags as inconsistent. Only surfaces once a PR's branch is rebased/merged onto the current `main`, which is why CI here needs it fixed too. Created with the help of an agent.
commit: |
Both were already broken on `main` (predate this branch and antfu#195) and would fail the new `e2e`/`a11y` jobs regardless of the split itself: - `instant.spec.ts` expected a button named 'Instant' and a plain-text 'npm registry' link role; the landing page's toggle has read 'Registry Query' since antfu#193 introduced the test, and the Overview panel's 'npm registry' was a plain `<span>`. Fixed the span to be a real link (matching its 'WebContainer' sibling) and updated the stale assertion. - `badge-color-gray` (used by `NodeVersionRange` with `!bg-active`) only cleared a 4.13:1 dark-mode contrast ratio — bumped the dark text shade following the same pattern as the other hue overrides above it. Created with the help of an agent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm test:e2e(and thee2eCI job) ran every Playwright project,including the
a11yproject's axe-core color-contrast scans, bundled inwith the actual e2e specs (dev/build/webcontainer/instant/build-subbase).
test:e2enow targets just the five e2e projects explicitly.test:a11yscript runs only thea11yproject.a11yjob mirroringe2e's Playwright setup (own runner,own cache, own artifact upload), so a11y regressions surface as their own
check and run in parallel with e2e instead of extending its runtime.
Also includes an unrelated one-line lint fix
(
packages/node-modules-tools/src/registry/resolve.test.ts, inconsistentobject-key quoting introduced by #195) needed to get
lintgreen onmainright now.
Created with the help of an agent.