Skip to content

refactor(tui): remove unused win32 ctrl-c guard - #43608

Closed
Hona wants to merge 1 commit into
anomalyco:v2from
Hona:remove-win32-guard
Closed

refactor(tui): remove unused win32 ctrl-c guard#43608
Hona wants to merge 1 commit into
anomalyco:v2from
Hona:remove-win32-guard

Conversation

@Hona

@Hona Hona commented Aug 20, 2026

Copy link
Copy Markdown
Member

Summary

  • remove the orphaned Windows Ctrl+C guard and its 100 ms polling interval from the Bun and Node TUI implementations
  • stop exporting the unused guard
  • pass the remaining GetConsoleMode output array through Bun FFI's buffer argument directly

The guard lost its final call site when the legacy V1 TUI startup path was removed in a43de3f. V2 still performs its active one-shot console mode clear after renderer creation.

Testing

  • bun typecheck in packages/tui
  • bun test in packages/tui (732 passed, 6 skipped)
  • repository pre-push typecheck (33 tasks passed)

Copilot AI lite review requested due to automatic review settings August 20, 2026 08:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Hona

Hona commented Aug 20, 2026

Copy link
Copy Markdown
Member Author

Superseded by #43604, which removes the entire OpenCode Win32 console-mode shim now that OpenTUI 0.5.4 owns raw-mode setup and cross-platform input flushing.

@Hona Hona closed this Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants