fix(keybinds): remove ctrl+c from default app_exit to prevent accidental exits - #43592
Open
Zhangbo-cn wants to merge 1 commit into
Open
fix(keybinds): remove ctrl+c from default app_exit to prevent accidental exits#43592Zhangbo-cn wants to merge 1 commit into
Zhangbo-cn wants to merge 1 commit into
Conversation
…tal exits Ctrl+C is the universal interrupt/copy key; binding it to exit by default closes the entire TUI on a single press when the prompt input is empty or during generation. Drop it from the app_exit default (Ctrl+D and <leader>q still exit) and sync the docs. Refs anomalyco#7957
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #7957
Type of change
What does this PR do?
ctrl+cis bound toapp_exitby default in the TUI, so pressing it with an empty prompt or during generation quits the whole app. That conflicts with the universal copy shortcut and has been reported in #7957 (and earlier in #2999); previous fix PRs (#11291, #9050) were auto-closed before landing.This PR removes
ctrl+cfrom theapp_exitdefault inpackages/tui/src/config/keybind.ts:"ctrl+c,ctrl+d,<leader>q"→"ctrl+d,<leader>q". Ctrl+D and<leader>qstill exit the app. Docs (18 locales) are synced.No tests assert the old default, so no test changes are needed.
How did you verify your code works?
<leader>qstill exit.Screenshots / recordings
Keybinding default change in the TUI; no visible UI diff. Can add a terminal recording if helpful.
Checklist