refactor(core): use Latch for shell output gate - #43573
Open
kitlangton wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The shell session's
outputDonesignal is a pure "output pump drained" gate — aDeferred<void>succeeded on both the success and catch paths of the pump fiber and awaited once infinish.Latchexpresses that open-once, never-failing intent directly.How
packages/core/src/shell.ts:outputDoneis nowLatch.makeUnsafe()(starts closed).outputDone.open.finishwaits withoutputDone.await.The value/error-carrying deferreds in the same file (
ready, waiterInforesolution) are correct asDeferredand unchanged. No behavior change. Found by a repo-wide audit ofDeferred<void>-as-gate patterns; sibling PRs convert the other pure-gate sites.Testing
packages/core:bun typecheck;bun test test/shell.test.ts test/shell-cleanup.test.ts test/tool-shell.test.ts(29 pass); fullbun run test(1908 tests, 0 fail).