Skip to content

Modify XPath for test name handling in converter - #51

Merged
xianyuanjia merged 2 commits into
android:mainfrom
lip-liu:patch-1
Jul 15, 2026
Merged

Modify XPath for test name handling in converter#51
xianyuanjia merged 2 commits into
android:mainfrom
lip-liu:patch-1

Conversation

@lip-liu

@lip-liu lip-liu commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Support retried or repeated test.

Support retried or repeated test.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates mobly_result_converter.py to search for test cases using the RERAN_TEST_NAME attribute instead of NAME. The reviewer identified a critical compatibility issue where this change breaks support for repeated or retried tests because xml.etree.ElementTree does not support boolean OR operators in XPath. The reviewer provided a robust Python-based matching solution to handle both attributes, which should be implemented.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/results_uploader/mobly_result_converter.py Outdated
Refactor XPath construction for test case retrieval to improve readability and maintainability.
@xianyuanjia

Copy link
Copy Markdown
Collaborator

Do you have an example Resultstore result that this applies to?

@lip-liu

lip-liu commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

@xianyuanjia
xianyuanjia self-requested a review July 15, 2026 17:09
@xianyuanjia
xianyuanjia merged commit f4ac0a8 into android:main Jul 15, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants