chore: web-test-runner - #1917
Draft
daniel-graham-amplitude wants to merge 1 commit into
Draft
Conversation
daniel-graham-amplitude
marked this pull request as draft
July 30, 2026 17:20
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Orphaned lockfile package entry
- Removed the orphaned packages/test-analytics-browser importer from pnpm-lock.yaml; pnpm install confirms the lockfile matches the real workspace.
Or push these changes by commenting:
@cursor push a2a6f44315
Preview (a2a6f44315)
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -1154,15 +1154,6 @@
specifier: ^7.0.2
version: 7.0.2(rollup@2.79.2)
- packages/test-analytics-browser:
- devDependencies:
- '@esm-bundle/chai':
- specifier: ^4.3.4
- version: 4.3.4
- '@web/test-runner':
- specifier: ^0.20.2
- version: 0.20.2
-
packages/unified:
dependencies:
'@amplitude/analytics-browser':You can send follow-ups to the cloud agent here.
Reviewed by Cursor Bugbot for commit 75d9fd0. Configure here.
| '@web/test-runner': | ||
| specifier: ^0.20.2 | ||
| version: 0.20.2 | ||
|
|
There was a problem hiding this comment.
Orphaned lockfile package entry
Low Severity
The lockfile gains an importers entry for packages/test-analytics-browser with @esm-bundle/chai and @web/test-runner, but that workspace package does not exist in the repo (only analytics-browser-test does). This looks like leftover state from the web-test-runner experiment.
Reviewed by Cursor Bugbot for commit 75d9fd0. Configure here.
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Experiment with test-runner integration testing
Checklist
Note
Low Risk
Test infrastructure and a non-runtime types re-export split; no production SDK behavior changes.
Overview
Adds browser integration testing for
@amplitude/analytics-browserusing @web/test-runner with Playwright (Chromium, Firefox, WebKit), esbuild, and Rollup CommonJS for node_modules.New
test:integrationscript andweb-test-runner.config.mjsserve from the monorepo root so pnpm workspace packages resolve. Smoke coverage includes track/identify/flush (smoke.test.ts), DOM click → track (smoke.test.html), and opt-out behavior.src/types.tsnow uses separateexport typevs valueexportblocks from@amplitude/analytics-core(likely to satisfy the browser test bundler). Lockfile picks up the new devDependencies.Reviewed by Cursor Bugbot for commit 75d9fd0. Bugbot is set up for automated code reviews on this repo. Configure here.