refactor: remove and replace analytics-client-common - #1905
Open
daniel-graham-amplitude wants to merge 2 commits into
Open
refactor: remove and replace analytics-client-common#1905daniel-graham-amplitude wants to merge 2 commits into
daniel-graham-amplitude wants to merge 2 commits into
Conversation
Contributor
size-limit report 📦
|
daniel-graham-amplitude
force-pushed
the
SDK-144-migrate-common-to-core
branch
from
July 23, 2026 23:39
88e1a8f to
664db0a
Compare
aliaksandr-kazarez
approved these changes
Jul 23, 2026
daniel-graham-amplitude
changed the title
Session Replay Browser E2E Results
Details
Flaky testschromium › e2e/shadow-dom.spec.ts › captureAdoptedStyleSheets option › SDK initializes without error and captures shadow host with captureAdoptedStyleSheets=false |
Mercy811
requested changes
Jul 24, 2026
Mercy811
left a comment
Mercy811
left a comment
Contributor
There was a problem hiding this comment.
Thanks @daniel-graham-amplitude, overall lgtm! Could you fix these comments? Thanks!
I confirm that right now only plugin SR and plugin web attribution actually imports client common package. SR and targeting are not actively using it at all. It's a unused dependency.
daniel-graham-amplitude
force-pushed
the
SDK-144-migrate-common-to-core
branch
from
July 29, 2026 21:43
664db0a to
ed1890f
Compare
… SDK-144-migrate-common-to-core
daniel-graham-amplitude
force-pushed
the
SDK-144-migrate-common-to-core
branch
from
July 29, 2026 22:39
803e59c to
dfa8119
Compare
daniel-graham-amplitude
enabled auto-merge (squash)
July 31, 2026 21:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Note
Medium Risk
Touches session replay, web attribution, and targeting dependency boundaries; incorrect re-exports or missed imports could break browser SDK behavior at runtime, though the change is primarily structural with no new public API described.
Overview
Removes the deprecated
@amplitude/analytics-client-commonworkspace package and updates the monorepo so consumers depend on@amplitude/analytics-core(and browser-local modules) instead.Dependency graph:
plugin-session-replay-browser,plugin-web-attribution-browser,session-replay-browser, andtargetingno longer listanalytics-client-common; session replay drops related transitive deps such asidb-keyvalandrrweb-packerfrom the lockfile where they were only pulled in through that path. The expo examplepnpm-lock.yamlis regenerated to match.Code that lived in client-common (attribution helpers, cookie/query utilities, connector wiring, default-tracking flags, etc.) is deleted from that package; callers are expected to use equivalents from
analytics-coreoranalytics-browser/ the web attribution plugin, per the PR intent.getAnalyticsConnectorfor session replay is pointed at core rather than client-common.Reviewed by Cursor Bugbot for commit dfa8119. Bugbot is set up for automated code reviews on this repo. Configure here.