test(session-replay-browser): SR-2728 nested JSON body masking e2e - #1901
Open
lewgordon-amplitude wants to merge 2 commits into
Open
test(session-replay-browser): SR-2728 nested JSON body masking e2e#1901lewgordon-amplitude wants to merge 2 commits into
lewgordon-amplitude wants to merge 2 commits into
Conversation
Cover excludelist masking on deeply nested request bodies in the network capture pipeline. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Collaborator
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
pruneJson removes empty parent objects after excluding leaf fields. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 94677d9. Configure here.
lewgordon-amplitude
changed the title
size-limit report 📦
|
Session Replay Browser E2E Results
Details
Flaky testschromium › e2e/shadow-dom.spec.ts › captureAdoptedStyleSheets option › SDK initializes without error and captures shadow host with default (true) |
|
Bugbot Autofix prepared a fix for the issue found in the latest run.
Or push these changes by commenting: Preview (5300530777)diff --git a/packages/session-replay-browser/e2e/capture.spec.ts b/packages/session-replay-browser/e2e/capture.spec.ts
--- a/packages/session-replay-browser/e2e/capture.spec.ts
+++ b/packages/session-replay-browser/e2e/capture.spec.ts
@@ -972,7 +972,7 @@
const evt = getFetchEvents().find((e) => String(e.url).includes('/graphql'));
expect(evt).toBeDefined();
expect(evt!.requestBody).toBe(
- '{"query":"mutation Login($input: LoginInput!) { login(input: $input) { id } }","variables":{"input":{}}}',
+ '{"query":"mutation Login($input: LoginInput!) { login(input: $input) { id } }"}',
);
});You can send follow-ups to the cloud agent here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
network-body-capture.test.tscoverapplyBodyMasking; branch pushed with e2e addition.Linear: SR-2728
Made with Cursor