Skip to content

Bugfix/wrong-docker-compose-ignore - #303

Merged
allohamora merged 1 commit into
masterfrom
bugfix/wrong-docker-compose-ignore
Aug 2, 2026
Merged

Bugfix/wrong-docker-compose-ignore#303
allohamora merged 1 commit into
masterfrom
bugfix/wrong-docker-compose-ignore

Conversation

@allohamora

@allohamora allohamora commented Aug 2, 2026

Copy link
Copy Markdown
Owner

Task

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the Docker ignore preset to exclude docker-compose.yml.
    • Updated generated Docker configurations to use the correct filename.
    • Revised automated checks to reflect the corrected behavior.

@github-actions github-actions Bot changed the title fix: remove . from docker-compose in dockerignore Bugfix/wrong-docker-compose-ignore Aug 2, 2026
@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 83157a05-7b69-4920-8916-10efcbc8b6c1

📥 Commits

Reviewing files that changed from the base of the PR and between 36f5a0d and 05a986d.

📒 Files selected for processing (3)
  • __tests__/unit/categories/js/docker/docker.installer.spec.ts
  • __tests__/unit/categories/js/docker/preset/index.spec.ts
  • src/categories/js/docker/preset/default.preset.ts

📝 Walkthrough

Walkthrough

The Docker ignore preset now excludes docker-compose.yml instead of .docker-compose.yml. The installer and preset tests use the updated expected value.

Changes

Docker ignore preset

Layer / File(s) Summary
Update Docker ignore entry
src/categories/js/docker/preset/default.preset.ts, __tests__/unit/categories/js/docker/preset/index.spec.ts, __tests__/unit/categories/js/docker/docker.installer.spec.ts
The default preset and related tests now use docker-compose.yml.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the Docker Compose ignore-pattern bugfix.
Linked Issues check ✅ Passed The changes implement issue #302 by replacing .docker-compose.yml with docker-compose.yml in the preset and tests.
Out of Scope Changes check ✅ Passed All changes directly support the Docker Compose ignore-pattern fix and its expected test updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bugfix/wrong-docker-compose-ignore

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@allohamora
allohamora merged commit 826cda1 into master Aug 2, 2026
5 checks passed
@allohamora
allohamora deleted the bugfix/wrong-docker-compose-ignore branch August 2, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant