feat: add collab-proof — AI collaboration retrospective skill

[dong7812]

Summary

Add collab-proof — an assisted retrospective skill that structures what Claude actually contributed in a session vs what the developer drove.

• Repo: https://github.com/dong7812/collab-proof
• Command: /collab-proof (installed separately via ./install.sh in the source repo)
• Zero external dependencies

What it is (and what it isn't)

Not a measurement system. D score is LLM-assessed with explicit rubric — directional indicator, not precise metric. Layer 01 (signal detection) is objective (git diff/file counts). Layer 02 uses conversation context.

The core output

```
AI contribution:

• Identified: TOCTOU window between ZCARD and ZADD developer had not noticed
• Suggested: Lua EVAL approach after reviewing Redis atomicity guarantees
• Developer-driven: Final implementation, choice of Lua over MULTI/EXEC
  ```

vs sessions where Claude just executed instructions:
```

• Developer-driven session. Claude executed instructions.
  ```

The rubric forces both sides to be named. Read the output and correct it if wrong.

What's in the diff

• engineering/collab-proof/.claude-plugin/plugin.json — plugin manifest (homepage/repo pointing to alirezarezvani/claude-skills)
• engineering/collab-proof/LICENSE — MIT
• engineering/collab-proof/skills/collab-proof/SKILL.md — full pipeline with YAML frontmatter
• engineering/collab-proof/skills/collab-proof/references/ — 4 reference docs (all public sources)
• .claude-plugin/marketplace.json — collab-proof entry added (category: engineering)

Checklist

• Target branch is dev
• SKILL.md with valid YAML frontmatter (name, description, license)
• marketplace.json entry added
• plugin.json points to alirezarezvani/claude-skills
• No hardcoded secrets
• No vendor-locked dependencies
• All references use public sources
• Follows existing directory structure

Type of Change

• New skill

[alirezarezvani]

Thanks for this — the concept is sharp (calibrated identified/suggested/developer-driven attribution is the right framing), the SKILL.md rubric is thoughtfully designed, and the four reference docs are genuinely well-sourced. A few things are blocking before it can merge.

Blocking

1. SKILL.md is missing YAML frontmatter.
The file opens directly with # collab-proof — there's no frontmatter block. Every SKILL.md in this repo requires:

---
name: "collab-proof"
description: "Use when ... <trigger phrases>"
license: MIT
---

This is enforced by the skill validators (scripts/audit_skills.py / skill_description_validator.py), so the skill won't pass CI without it. The PR checklist ticks "valid YAML frontmatter," but it's absent in the diff.

2. No marketplace.json registration entry.
The skill needs an entry in the root .claude-plugin/marketplace.json to be distributable (same item that blocked #784). Please add it with the canonical source path and category: engineering.

3. The PR description claims a /collab-proof command and SessionEnd/Stop hooks ("full automation"), but neither is in the diff.
The diff contains only plugin.json, LICENSE, SKILL.md, and 4 references — no commands/ file and no hook config. Either ship the command + hook (with the non-blocking async behavior you describe), or remove those claims from the PR body so the description matches what's delivered.

Should-fix

4. plugin.json homepage and repository point to your personal repo (github.com/dong7812/collab-proof). Every other plugin.json in this repo points to alirezarezvani/claude-skills (homepage to the /tree/main/... path of the skill). Please align so links resolve in the published marketplace.

5. Local-only reference path. references/session-documentation-patterns.md cites Reference: Vela pipeline design at /Users/dongkyu/learning/vela (local reference implementation) — that's a dead reference for anyone else. Please replace with a public source or drop it.

Non-blocking (nice to have)

6. No scripts/. The SKILL.md inlines fairly heavy bash/python (token analysis, HTML generation). The library convention is 3 stdlib tools per skill; a script-native skill is defensible (cf. youtube-full) but extracting the token-analysis + HTML-proof generators into scripts/ would make them testable via script_tester.py and keep the SKILL.md focused on workflow.

Items 1–3 are blocking. Happy to re-review once those are in — targeting dev is correct 👍

---

Reviewed via Claude Code.

---

Generated by Claude Code

[dong7812]

Thanks for the detailed review — addressed all blocking and should-fix items:

Blocking

1. Added YAML frontmatter to SKILL.md (name, description, license)
2. Added collab-proof entry to .claude-plugin/marketplace.json (category: engineering)
3. Removed commands/hooks claims from PR description — /collab-proof command and hooks are installed separately via ./install.sh in the source repo and aren't part of this diff. PR body now reflects exactly what's delivered.

Should-fix
4. plugin.json homepage and repository now point to alirezarezvani/claude-skills (tree path for homepage, repo root for repository)
5. Replaced dead local path reference (/Users/dongkyu/learning/vela) with a public link in references/session-documentation-patterns.md

Non-blocking (6)
Looked into extracting the token analysis and HTML generation into scripts/, but the testing benefit relies on script_tester.py — which does AST parsing, import checking, and argparse validation for Python .py files specifically. The inline code uses python3 -c "..." one-liners (stdlib only, no pip), so extracting them to bash scripts would skip the tester entirely and lose the testability benefit you were pointing at.

Given that you noted a script-native skill is defensible, I'll leave the inline approach as-is. Happy to revisit if there's a path that gets them into script_tester.py coverage.

[alirezarezvani]

Thanks for the updates — re-reviewed the latest commit (eeda78b). The blocking items from the earlier review are resolved:

• ✅ SKILL.md frontmatter — now present and valid (name, description, license: MIT).
• ✅ marketplace.json entry added (category engineering).
• ✅ plugin.json homepage/repository point to alirezarezvani/claude-skills.
• ✅ The /collab-proof command + hook are now scoped to the source repo's installer rather than over-claimed in the diff.

One thing left before this can merge: the PR currently has a merge conflict with dev (mergeable_state: dirty — dev has advanced since you branched). Could you rebase onto the latest dev (or merge dev in) and push? Once it's mergeable again it's good for a maintainer merge from my side.

git fetch upstream                 # alirezarezvani/claude-skills
git checkout add-collab-proof-new
git rebase upstream/dev            # resolve any conflicts, e.g. in .claude-plugin/marketplace.json
git push --force-with-lease

The conflict is almost certainly in marketplace.json (lots of entries land there) — keep both your collab-proof entry and whatever else dev added.

---

Generated by Claude Code