Move internal test helper to rig scripts - #20
Merged
Conversation
Refs #19 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
alex-mextner
marked this pull request as ready for review
July 9, 2026 09:36
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a4e6e5e2e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Refs #21 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
3 tasks
Keep rig.yaml scripts.test as the primary repo test surface while allowing fresh clones that lack the external dev CLI to run the maintained repo test gate directly through the literal rig script. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
3d testgate intorig.yamlscripts.testfordev run testtestcommand module and command docs from the public3dCLI surfacedev run testand preserve migration guidance for3d testTests
uv run --with pytest --with pyyaml pytest -q tests/test_dispatch.py tests/test_test_gate_dependencies.py tests/test_install_dev_hooks.pyPYTHONPATH=/Users/ultra/xp/agent-tools/.worktrees/feat-dev-cli-207/lib python3 -m agenttools_dev run test -- -k test_rig_yaml_declares_the_full_test_gate_scriptfromtests/PYTHONPATH=/Users/ultra/xp/agent-tools/.worktrees/feat-dev-cli-207/lib python3 -m agenttools_dev run test(3211 passed, 6 skipped; 2 existing warnings)dev run testgate successfully before commitReview
review diff --task 3d-cli-19 -C /Users/ultra/xp/3d-cli/.worktrees/feat-dev-cli-19was run without an external timeout.Blockers
rigrejects top-levelscriptswithunknown top-level key: scripts./Users/ultra/xp/rig-cli/.worktrees/feat-dev-cli-117) accepts this config and proceeds to normal drift reporting.scriptsis landed/applied.Refs #19