Skip to content

Move internal test helper to rig scripts - #20

Merged
alex-mextner merged 3 commits into
mainfrom
feat/dev-cli-19
Jul 9, 2026
Merged

Move internal test helper to rig scripts#20
alex-mextner merged 3 commits into
mainfrom
feat/dev-cli-19

Conversation

@alex-mextner

Copy link
Copy Markdown
Owner

Summary

  • move the internal 3d test gate into rig.yaml scripts.test for dev run test
  • remove the test command module and command docs from the public 3d CLI surface
  • update docs, repo-dev hook, and tests to point at dev run test and preserve migration guidance for 3d test

Tests

  • uv run --with pytest --with pyyaml pytest -q tests/test_dispatch.py tests/test_test_gate_dependencies.py tests/test_install_dev_hooks.py
  • PYTHONPATH=/Users/ultra/xp/agent-tools/.worktrees/feat-dev-cli-207/lib python3 -m agenttools_dev run test -- -k test_rig_yaml_declares_the_full_test_gate_script from tests/
  • PYTHONPATH=/Users/ultra/xp/agent-tools/.worktrees/feat-dev-cli-207/lib python3 -m agenttools_dev run test (3211 passed, 6 skipped; 2 existing warnings)
  • commit hook also ran the full dev run test gate successfully before commit

Review

  • review diff --task 3d-cli-19 -C /Users/ultra/xp/3d-cli/.worktrees/feat-dev-cli-19 was run without an external timeout.
  • Final run was degraded because Codex hit a local usage/skill failure and commandcode reserve reviewers had no credits; usable Opus and Gemini reviews reported no blocking logic bugs after follow-up fixes.

Blockers

  • Draft until the broader dev-cli work lands: current installed rig rejects top-level scripts with unknown top-level key: scripts.
  • Verified the sibling rig-cli dev branch (/Users/ultra/xp/rig-cli/.worktrees/feat-dev-cli-117) accepts this config and proceeds to normal drift reporting.
  • Do not ship/merge until agent-tools dev CLI + rig-cli schema support for scripts is landed/applied.

Refs #19

Refs #19

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@alex-mextner
alex-mextner marked this pull request as ready for review July 9, 2026 09:36
@alex-mextner alex-mextner mentioned this pull request Jul 9, 2026
4 tasks

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6a4e6e5e2e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/hooks/pre-commit Outdated
Refs #21

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Keep rig.yaml scripts.test as the primary repo test surface while allowing fresh clones that lack the external dev CLI to run the maintained repo test gate directly through the literal rig script.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@alex-mextner
alex-mextner merged commit bbb984e into main Jul 9, 2026
8 of 9 checks passed
@alex-mextner
alex-mextner deleted the feat/dev-cli-19 branch July 9, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant