reset command_timeout on interactive command when output is received …#254
Merged
thorinaboenke merged 3 commits intoJun 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…also when prompt is set
Task
#253
When prompts were configured (which is the default: ['$ ', '# ', '> ']), the interactive mode timer was only reset via the else branch of check_prompt, which was never reached when prompts were set. This caused command_timeout to count from when the command was dispatched rather than from the last received output, silently cutting off long-running commands
Moving set_timer() outside the else block ensures the timer resets on every received chunk unless a prompt match is found and the loop exits.
Description
fix: reset interactive SSH timeout on every received output chunk, not only when no prompts are configured
check_prompt is now:
How Has This Been Tested?
Checklist