refactor(proto): split schema by domain#8
Merged
Conversation
Signed-off-by: Connor Carpenter <connorc@nvidia.com>
Signed-off-by: Connor Carpenter <connorc@nvidia.com>
Signed-off-by: Connor Carpenter <connorc@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openengine.v1schema into domain-oriented proto filesopenengine.v1.OpenEngineservice and one protobuf packageopenengine.protoas the service entry pointWhy
The schema had grown to 708 lines, 79 message and enum types, and 14 RPCs across generation, discovery, lifecycle, LoRA, KV, and observability domains. Domain files make the contract easier to navigate and evolve without introducing new protobuf packages or services.
Impact
All message, enum, service, and RPC descriptors are unchanged. Generated source now spans domain-specific modules, so consumers must compile every
.protofile underproto/openengine/v1/rather than compiling onlyopenengine.proto.Validation
buf buildbuf lintbuf format --diff --exit-codemain: 80 top-level symbols matchedOpenEngineStubimport: 20 generated modulesmarkdownlint-cli20.23.0: 0 errors