fix(agui): cancel MVC subscription on disconnect - #2786
Open
logicwu0 wants to merge 4 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
interruptOnDisconnectis enabledWhy this is still needed
The behavior reported on 2.0.1 had more than one lifecycle problem. #2646 fixed one part by preventing the conflicting
RUN_ERRORfollowed byRUN_FINISHEDsequence.However, that change did not cancel the MVC Reactor subscription when the SSE connection fails or times out. On the latest
main(bf7b7dae), the controller only interrupts the agent. The active-run entry is still released by the event stream'sdoFinally, so an immediate request on the same thread can still be rejected while upstream termination is delayed.Disposing the subscription after requesting interruption triggers the cancellation lifecycle immediately and lets
doFinallyrelease the thread.Tests
interruptOnDisconnectkeeps the first run activeFixes #2782