feat: keep file tabs alive across switches to preserve viewer state - #451
Open
111-test-111 wants to merge 1 commit into
Open
feat: keep file tabs alive across switches to preserve viewer state#451111-test-111 wants to merge 1 commit into
111-test-111 wants to merge 1 commit into
Conversation
The right panel previously rendered only the active file tab, so every tab switch unmounted the previous FileViewer and lost its scroll position, zoom, and viewer state. Now all open tabs stay mounted and inactive ones are hidden with display:none; closing a tab (removing it from fileTabs) still unmounts and frees it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The right file panel currently unmounts the previous tab's
FileVieweron every tab switch, losing scroll position, zoom, and viewer state. This renders all open tabs and hides inactive ones withdisplay:none; closing a tab (removal fromfileTabs) still unmounts and frees it.Notes
AppShell.keep-alive.test.mjs. Full suite: 428 pass / 0 fail;tsc --noEmitand eslint clean.