Skip to content

change ping signature #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BartolomeyKant merged 1 commit into from
Jun 29, 2026
Merged

change ping signature #497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion aether/ae_actions/ping.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ void Ping::SendPing() {
std::chrono::duration_cast<std::chrono::milliseconds>(
ping_interval_)
.count());
auto& pong_promise = auth_api->ping(ping_interval_u64);
// FIXME: for rx_window send interval value
auto& pong_promise =
auth_api->ping(ping_interval_u64, ping_interval_u64);
auto req_id = pong_promise.request_id();

// save the ping request
Expand Down
4 changes: 3 additions & 1 deletion aether/work_cloud_api/work_server_api/authorized_api.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ class AuthorizedApi : public ApiClass {
public:
explicit AuthorizedApi(ProtocolContext& protocol_context);

Method<4, ApiPromise<void>(std::uint64_t next_connect_ms_duration)> ping;
Method<4, ApiPromise<void>(std::uint64_t next_connect_ms_duration,
std::uint64_t rx_window_ms)>
ping;
Method<6, void(AeMessage message)> send_message;
Method<7, void(std::vector<AeMessage> messages)> send_messages;
Method<11, ApiPromise<void>(Uid uid)> check_access_for_send_message;
Expand Down
Loading