[CLIENT-5049] Convert existing code examples in examples/ folder to inherit from a base class for boilerplate setup - #1149
Open
juliannguyen4 wants to merge 67 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1149 +/- ##
=======================================
Coverage 85.46% 85.46%
=======================================
Files 101 101
Lines 14661 14661
=======================================
Hits 12530 12530
Misses 2131 2131 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…. TODO - Because of the C# client's fixture system, I'm wondering if we can just use pytest
…t support this. Also remove outdated python 2 compatibility code
…isting-code-examples-to-use-harness-class
…isting-code-examples-to-use-harness-class
…isting-code-examples-to-use-harness-class
…isting-code-examples-to-use-harness-class
…_examples to prevent exceptions being suppressed during cleanup.
juliannguyen4
marked this pull request as ready for review
July 29, 2026 17:07
…ting admin examples to use harness system.
…he only place that uses it.
…les while logged in. I believe customers starting out with aerospike would use CE before trying a build with EE features like security.
…ust have the sys-admin role. We can add it since admin user has user-admin role by default.
…esn't take long to collect all the example classes.
…isting-code-examples-to-use-harness-class
shannonklaus
requested changes
Aug 7, 2026
shannonklaus
left a comment
shannonklaus
left a comment
There was a problem hiding this comment.
Please ensure that the copyright year is updated in every changed file
…isting-code-examples-to-use-harness-class
…ent that were changed in this PR
atripathi-aerospike
approved these changes
Aug 7, 2026
atripathi-aerospike
left a comment
atripathi-aerospike
left a comment
There was a problem hiding this comment.
Looks good to me. Copyright year update needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is preparation for the aerospike.com documentation to reuse examples from
examples/client.CI/CD: Validate all code examples in
examples/clientNotes
Code examples will be tweaked later on once they are included in the aerospike.com docs, so they may not be in a final state.
Extra changes
Remove the outdated async examples
Risks
Code examples can no longer take in parameters, so users must manually tweak the examples before running them.
TODO
Out of scope
run_all_examplesfails if not run from repo root directory