fix(ApiUrl): show correct PUBLISH/SUBSCRIBE labels for AsyncAPI operations (@W-21813981)#98
Merged
Merged
Conversation
|
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Alex Perez <a***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request. |
…yncAPI operations The local _isGrpcOperation override in ApiUrl.js treated publish/subscribe method names as gRPC indicators, causing AsyncAPI operations to display "CLIENT"/"SERVER" labels instead of "PUBLISH"/"SUBSCRIBE". The inherited AmfHelperMixin implementation correctly identifies gRPC by payload media type. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
alexpmule
force-pushed
the
fix/W-21813981-asyncapi-operation-labels
branch
from
302d6af to
29fc905
Compare
Verify that the method-label element displays PUBLISH/SUBSCRIBE (not CLIENT/SERVER) for AsyncAPI operations in both compact and full models. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
alexpmule
changed the title
spezzirriemiliano
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since the gRPC support PR (#97), AsyncAPI operations display "CLIENT"/"SERVER" labels instead of the correct "PUBLISH"/"SUBSCRIBE".
Root cause:
ApiUrl.jsadded a local_isGrpcOperationoverride that matched method names (publish,subscribe) to detect gRPC. This incorrectly flagged all AsyncAPI operations as gRPC. The inheritedAmfHelperMixin._isGrpcOperationcorrectly identifies gRPC by checking payload media type (application/grpc).Fix
_isGrpcOperationoverride (defer to mixin's media-type check)_getGrpcStreamTypeoverride (same reason)_getGrpcStreamTypeDisplayNameand_getMethodForColor(rendering helpers, not in mixin)Net result: -67 lines. gRPC operations still render correctly; AsyncAPI operations now show their real method name.
Screenshots
AsyncAPI (fixed):
gRPC (still works):
Tests