#608 Update panel.js to maxWidth .85 to match layout view panel sizing - #609
Open
pgoodrich wants to merge 1 commit into
Open
#608 Update panel.js to maxWidth .85 to match layout view panel sizing#609pgoodrich wants to merge 1 commit into
pgoodrich wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #608.
da-nx/nx2/utils/panel.js
Line 4 in fe5e950
const PANEL_WIDTH_MAX = () => Math.min(1600, window.innerWidth * 0.4);
sets the max width of the panel to .4 of the window innerWidth. This is quite small for the plugins we want to implement. Our use cases are a downstream app preview (consumes EDS content) and Target campaign management within the panel.
Ideally this would like work more like Layout view where I can freely drag the panel size to have up to more like a 85-15 panel split.
Test URLs: