Skip to content

Make loc aware of msm - #606

Open
ravuthu wants to merge 3 commits into
mainfrom
loc-msm
Open

Make loc aware of msm#606
ravuthu wants to merge 3 commits into
mainfrom
loc-msm

Conversation

@ravuthu

@ravuthu ravuthu commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

@aem-code-sync

aem-code-sync Bot commented Jul 16, 2026

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@hannessolo

Copy link
Copy Markdown
Contributor

Hi, in order to review this could you share come context - who will use this and what exactly does it do?

Base automatically changed from locnx2 to main July 22, 2026 20:08
if (resp.ok) return { resp, resolvedSite: ancestor, inherited: true };
}

return { resp: selfResp, resolvedSite: site, inherited: false };

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please hoist const selfResult = { resp: selfResp, resolvedSite: site, inherited: false } once and return it in the ok / non-404 / no-rows / fallthrough paths. four copies is easy to let drift.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants