You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Users can select text, an image or a table (block) and attach a comment. Each comment is stored as a .json file in .da/comments/{docId}/{commentId}.json
When a selection is made, a comment icon is also added to the toolbar in EW to initiate a thread.
Supports replies/threads, resolve/unresolve & orphan threads (user comments on something, the content is deleted while the comment is still active).
Comment data will survive if a page is moved to another folder.
Keyboard Shortcuts
CMD+Option+M — if there is a selection, will start composing a new thread.
CMD+Enter to submit a comment/reply
Read-Only Users
Read only users who should have access to comment only would need to be given write permissions to /{site}/.da/comments/ + ** in the DA config.
Layout Mode
Layout mode currently doesn't show a toolbar at all when a block is selected. The comment button should be made available there as part of the work done in SITES-46128
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.
Thanks for your contribution and for your patience!
One architecture note: since you opened this PR, we've standardized how components talk to each other. Communication within the canvas itself now goes through a shared pub/sub bus, and communication that crosses from canvas into the panel has a standard eventing mechanism it should be going through consistently. Could you please update your PR to use these?
Thanks for your contribution and for your patience! One architecture note: since you opened this PR, we've standardized how components talk to each other. Communication within the canvas itself now goes through a shared pub/sub bus, and communication that crosses from canvas into the panel has a standard eventing mechanism it should be going through consistently. Could you please update your PR to use these?
done. routed canvas stuff through canvasBus and canvas > panel through PANEL_EVENT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be merged with adobe/da-nx#562
Summary
Collaborative comments for Experience Workspace.
Users can select text, an image or a table (block) and attach a comment. Each comment is stored as a .json file in
.da/comments/{docId}/{commentId}.jsonWhen a selection is made, a comment icon is also added to the toolbar in EW to initiate a thread.
Supports replies/threads, resolve/unresolve & orphan threads (user comments on something, the content is deleted while the comment is still active).
Comment data will survive if a page is moved to another folder.
Keyboard Shortcuts
CMD+Option+M— if there is a selection, will start composing a new thread.CMD+Enterto submit a comment/replyRead-Only Users
Read only users who should have access to comment only would need to be given write permissions to
/{site}/.da/comments/ + **in the DA config.Layout Mode
Layout mode currently doesn't show a toolbar at all when a block is selected. The comment button should be made available there as part of the work done in SITES-46128
How Has This Been Tested?
Screenshots (if appropriate)
Types of changes
Checklist