Restructure into otfautohint tests - #5
Draft
skef wants to merge 1 commit into
Draft
Conversation
committed to afdko repository)
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many of the tests from this repo (mostly from the dummy directory) were ported to the
otfautohintbranch of afdko, to be added there. This draft PR represents the remaining tests. The hinted fonts and/or reference files have been updated to match the pyport of the autohinter (and have not been checked in detail in doing so -- I'm relying on our past assessments of improved quality of hinting).In theory we could integrate this branch and then instrument this repository to run the tests, possibly adding some sort of requirements file that the dependency-bot would auto-update. That would tell us if things have changed, albeit slightly after the fact. Then we would presumably either update the test files or examine the code changed in afdko to see if there is a problem.