Skip to content

fix: quote SessionStart hook path#228

Draft
Bortlesboat wants to merge 1 commit into
addyosmani:mainfrom
Bortlesboat:fix/sessionstart-space-safe-hook-path
Draft

fix: quote SessionStart hook path#228
Bortlesboat wants to merge 1 commit into
addyosmani:mainfrom
Bortlesboat:fix/sessionstart-space-safe-hook-path

Conversation

@Bortlesboat

Copy link
Copy Markdown
Contributor

Summary

  • quote the CLAUDE_PLUGIN_ROOT expansion in the SessionStart hook command
  • add a regression check that locks the hook command string in hooks/hooks.json

Verification

  • hooks/session-start-test.sh passed from an LF-normalized temp checkout on Windows
  • executed the SessionStart hook command from a temp path containing spaces and confirmed it returned the expected JSON payload

Closes #214.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SessionStart hook fails when plugin path contains a space (unquoted ${CLAUDE_PLUGIN_ROOT})

1 participant