Fix: stop register-super failing against a running app (fixes #123) - #124
Merged
Conversation
|
🎉 This PR is included in version 1.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #123
Fix
registerSuperUserintolib/utils/isAppRunning.js, and treat any HTTP response as proof the app is running — including an error status. The probe requests the API endpoint map, which requires authentication, so an unauthenticated probe against a live instance gets a 401 rather than a 200. The old code only toleratedECONNREFUSEDand rethrew everything else, soregister-superaborted withMISSING_AUTH_HEADER (401)before reachingauth/local/registersuper.startApp(). Errors that are neither a response nor a refused connection (a missing conf file, an unreachable host) still propagate, so genuine misconfiguration isn't swallowed into a spurious in-process boot.Testing
tests/isAppRunning.spec.jscovering all six branches: success, a 401, other error statuses,ECONNREFUSED, a non-transport error, and a non-ECONNREFUSEDtransport error.standardclean.