Skip to content

Add configurable automation failure notifications#52

Merged
adampoit merged 3 commits into
mainfrom
issue-50-maintainer-notifications
Jul 18, 2026
Merged

Add configurable automation failure notifications#52
adampoit merged 3 commits into
mainfrom
issue-50-maintainer-notifications

Conversation

@adampoit

Copy link
Copy Markdown
Owner

Summary

  • add optional GitHub issue notifications for sync, CI, and promotion failures
  • upsert and assign durable failure issues, with optional close-on-recovery behavior
  • integrate notification and recovery steps into generated workflows with conditional issues: write permissions
  • validate notification configuration, workflow permissions, and assignability in doctor
  • include structured, non-secret failure context and preserve original automation failures when notification APIs fail

Testing

  • npm test
  • npm run format:check
  • language-server diagnostics

Closes #50

@not-adam

not-adam Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Mira PR Walkthrough

Adds configurable GitHub issue notifications for sync, CI, and promotion failures in generated GitHub Actions workflows. Notification and recovery steps are conditionally emitted based on notifications.githubIssues config, with issues: write permissions added only when needed. Failure steps use continue-on-error to preserve the original automation outcome.

graph LR
    templates["src/workflow-templates.ts"]
    tests["tests/workflow-templates.test.ts"]
    tests --> templates
Loading
Confidence: 4/5   ◉◉◉◉○   Safe with minor fixes
  • Notification steps use continue-on-error and never block workflows; tests cover positive, negative, and no-notification cases.

Blast Radius — 2 dependent repositories, 3 total references

adampoit/mira — 1 reference
adampoit/wezterm — 2 references

2 files reviewed


Comment @not-adam help to get the list of available commands and usage tips.

@not-adam not-adam Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mira Review Summary

A security concern in src/workflow-templates.ts at line 113 involves unescaped interpolation of config.syncBranch into a GitHub Actions workflow expression, which could allow expression injection if the branch name contains special characters such as single quotes.

Comment thread src/workflow-templates.ts
@adampoit
adampoit merged commit 6c033fd into main Jul 18, 2026
2 checks passed
@adampoit
adampoit deleted the issue-50-maintainer-notifications branch July 18, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add configurable maintainer notifications for automation failures

1 participant