fix: e2e_tests check don't work on a PR from a fork due to AWS' configure-aws-credentials bug - #439
Open
webbrain-one wants to merge 1 commit into
Open
fix: e2e_tests check don't work on a PR from a fork due to AWS' configure-aws-credentials bug#439webbrain-one wants to merge 1 commit into
webbrain-one wants to merge 1 commit into
Conversation
Work around the AWS credentials bug causing failures on fork PRs. Ref: aws-actions/configure-aws-credentials#564 Fixes activescott#205
There was a problem hiding this comment.
Pull request overview
This PR updates the e2e_tests workflow steps to avoid running AWS remote end-to-end tests for pull requests coming from forks (to work around the aws-actions/configure-aws-credentials failure mode described in #205).
Changes:
- Adds conditional execution to the AWS credentials configuration step.
- Adds conditional execution to the remote e2e prepare/run steps.
- Adds conditional execution to the remote e2e cleanup step.
Suppressed comments (3)
.github/workflows/build.yml:120
- Same issue as above: on
pushevents this will be skipped becausegithub.event.pull_requestis unset, so remote e2e prep won't run on trusted branches. Use a condition that only excludes forked PRs.
- name: prepare to run remote end-to-end test
if: ${{ github.event.pull_request.head.repo.fork == false }}
run: |
.github/workflows/build.yml:128
- Same issue as above: this
ifblocks remote e2e execution onpushbecausegithub.event.pull_requestis unset. Adjust the condition so pushes still run and only forked PRs skip.
- name: run remote end-to-end test
if: ${{ github.event.pull_request.head.repo.fork == false }}
run: |
.github/workflows/build.yml:160
- This cleanup step will also be skipped on
pushevents due to thegithub.event.pull_request...check, which is inconsistent with the intent to always clean up remote e2e resources after a push run. Gate only forked PRs while keepingalways()behavior.
- name: cleanup remote end-to-end test (destroy serverless stack)
# Run this step even if the prior one failed (to clean up)
if: ${{ always() && github.event.pull_request.head.repo.fork == false }}
run: |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
108
to
110
| - name: configure aws credentials | ||
| if: ${{ github.event.pull_request.head.repo.fork == false }} | ||
| # Configures AWS credential and region environment variables for use in other GitHub Actions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #205