Skip to content

fix: e2e_tests check don't work on a PR from a fork due to AWS' configure-aws-credentials bug - #439

Open
webbrain-one wants to merge 1 commit into
activescott:mainfrom
webbrain-one:webbrain/issue-205
Open

fix: e2e_tests check don't work on a PR from a fork due to AWS' configure-aws-credentials bug#439
webbrain-one wants to merge 1 commit into
activescott:mainfrom
webbrain-one:webbrain/issue-205

Conversation

@webbrain-one

Copy link
Copy Markdown

Closes #205

Work around the AWS credentials bug causing failures on fork PRs.

Ref: aws-actions/configure-aws-credentials#564
Fixes activescott#205

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the e2e_tests workflow steps to avoid running AWS remote end-to-end tests for pull requests coming from forks (to work around the aws-actions/configure-aws-credentials failure mode described in #205).

Changes:

  • Adds conditional execution to the AWS credentials configuration step.
  • Adds conditional execution to the remote e2e prepare/run steps.
  • Adds conditional execution to the remote e2e cleanup step.
Suppressed comments (3)

.github/workflows/build.yml:120

  • Same issue as above: on push events this will be skipped because github.event.pull_request is unset, so remote e2e prep won't run on trusted branches. Use a condition that only excludes forked PRs.
      - name: prepare to run remote end-to-end test
        if: ${{ github.event.pull_request.head.repo.fork == false }}
        run: |

.github/workflows/build.yml:128

  • Same issue as above: this if blocks remote e2e execution on push because github.event.pull_request is unset. Adjust the condition so pushes still run and only forked PRs skip.
      - name: run remote end-to-end test
        if: ${{ github.event.pull_request.head.repo.fork == false }}
        run: |

.github/workflows/build.yml:160

  • This cleanup step will also be skipped on push events due to the github.event.pull_request... check, which is inconsistent with the intent to always clean up remote e2e resources after a push run. Gate only forked PRs while keeping always() behavior.
      - name: cleanup remote end-to-end test (destroy serverless stack)
        # Run this step even if the prior one failed (to clean up)
        if: ${{ always() && github.event.pull_request.head.repo.fork == false }}
        run: |

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 108 to 110
- name: configure aws credentials
if: ${{ github.event.pull_request.head.repo.fork == false }}
# Configures AWS credential and region environment variables for use in other GitHub Actions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

e2e_tests check don't work on a PR from a fork due to AWS' configure-aws-credentials bug

2 participants