Added ability to ignore tags when deleting packages - #104
Open
Hayena wants to merge 2 commits into
Open
Conversation
Hayena
force-pushed
the
include-tags-ignore-version
branch
from
April 18, 2023 15:02
0dcd581 to
bf25fb8
Compare
|
The inverse of this would also be very nice. "Delete only these tags". |
|
This would be a very helpful for maintaining container packages. Would be great if we can get a reviewer! |
|
Any plans on merging this PR? |
|
What is the status? This would be great! |
AtomicFS
added a commit
to 9elements/firmware-action
that referenced
this pull request
Feb 28, 2024
- add a step in docker-build-and-test to delete old published containers - should delete all but 'main', 'latest' and release containers - we have to use my own fork of actions/delete-package-versions at the moment to have access to 'dry-run' and 'ignore-versions-include-tags' features - [dry-run](https://github.com/actions/delete-package-versions/pull/119/commits) - [tags](actions/delete-package-versions#104) Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
AtomicFS
added a commit
to 9elements/firmware-action
that referenced
this pull request
Feb 29, 2024
- add a step in docker-build-and-test to delete old published containers - should delete all but 'main', 'latest' and release containers - we have to use my own fork of actions/delete-package-versions at the moment to have access to 'dry-run' and 'ignore-versions-include-tags' features - [dry-run](https://github.com/actions/delete-package-versions/pull/119/commits) - [tags](actions/delete-package-versions#104) Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
AtomicFS
added a commit
to 9elements/firmware-action
that referenced
this pull request
Mar 1, 2024
- add a step in docker-build-and-test to delete old published containers - should delete all but 'main', 'latest' and release containers - we have to use my own fork of actions/delete-package-versions at the moment to have access to 'dry-run' and 'ignore-versions-include-tags' features - [dry-run](https://github.com/actions/delete-package-versions/pull/119/commits) - [tags](actions/delete-package-versions#104) Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
github-merge-queue Bot
pushed a commit
to 9elements/firmware-action
that referenced
this pull request
Mar 4, 2024
- add a step in docker-build-and-test to delete old published containers - should delete all but 'main', 'latest' and release containers - we have to use my own fork of actions/delete-package-versions at the moment to have access to 'dry-run' and 'ignore-versions-include-tags' features - [dry-run](https://github.com/actions/delete-package-versions/pull/119/commits) - [tags](actions/delete-package-versions#104) Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
AtomicFS
added a commit
to 9elements/firmware-action
that referenced
this pull request
Mar 4, 2024
- add a step in docker-build-and-test to delete old published containers - should delete all but 'main', 'latest' and release containers - we have to use my own fork of actions/delete-package-versions at the moment to have access to 'dry-run' and 'ignore-versions-include-tags' features - [dry-run](https://github.com/actions/delete-package-versions/pull/119/commits) - [tags](actions/delete-package-versions#104) Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
github-merge-queue Bot
pushed a commit
to 9elements/firmware-action
that referenced
this pull request
Mar 4, 2024
- add a step in docker-build-and-test to delete old published containers - should delete all but 'main', 'latest' and release containers - we have to use my own fork of actions/delete-package-versions at the moment to have access to 'dry-run' and 'ignore-versions-include-tags' features - [dry-run](https://github.com/actions/delete-package-versions/pull/119/commits) - [tags](actions/delete-package-versions#104) Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
davidfevre-gouv-nc
approved these changes
May 29, 2024
Co-authored-by: David Fèvre <62677553+davidfevre-gouv-nc@users.noreply.github.com>
|
this feature would be very useful cc @jidicula |
Contributor
|
@davidfevre-gouv-nc any chance of getting this merged? |
Contributor
Hi @AtomicFS, I added my code review to mark my interest in this feature but I am not part of the CODEOWNERS, so not able to merge 😞 |
|
@davidfevre-gouv-nc Oh I see, sorry for the unnecessary ping. |
|
Any updates on this? Would be great if it could be merged. |
|
Maybe @conorsloan could help ? By the way, I now use vlaurin/action-ghcr-prune. |
|
I am also watching this issue to see how it does. FWIW, I use emmahsax/action-ghcr-prune (which is a fork of a fork of vlaurin's version). |
|
Can we merge this? |
2 tasks
|
This is a nice feature, i hope will be merged soon |
It is open and waiting since 2023, that is 3 years in few days, I doubt anything will happen anytime soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a possible implementation for #88. This implementation adds a input parameter to enable ignoring of tags based on the existing
ignore-versionsinput