feat(verification): add GoLang support for Docker-based verification#272
Open
apoorv7g wants to merge 4 commits into
Open
feat(verification): add GoLang support for Docker-based verification#272apoorv7g wants to merge 4 commits into
apoorv7g wants to merge 4 commits into
Conversation
This adds end-to-end Go verification to the codegen pipeline: GitHub Actions matrix support, npm docker-run script wiring, a new Go docker target/image/entrypoint, and a new `golang.compile.test.js` suite that generates Go and runs `go build`. It also updates verification case metadata and corpus manifest with explicit `golang` skip reasons for known cross-namespace import path issues emitted by `GoLangVisitor`, keeping failures intentional and documented. Signed-off-by: Apoorv <130035517+APOORV7G@users.noreply.github.com>
This adds end-to-end Go verification to the codegen pipeline: GitHub Actions matrix support, npm docker-run script wiring, a new Go docker target/image/entrypoint, and a new `golang.compile.test.js` suite that generates Go and runs `go build`. It also updates verification case metadata and corpus manifest with explicit `golang` skip reasons for known cross-namespace import path issues emitted by `GoLangVisitor`, keeping failures intentional and documented. Signed-off-by: Apoorv <130035517+APOORV7G@users.noreply.github.com>
Signed-off-by: Apoorv Gadiya <130035517+apoorv7g@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds end-to-end Go verification to the codegen pipeline: GitHub Actions matrix support, npm docker-run script wiring, a new Go docker target/image/entrypoint, and a new
golang.compile.test.jssuite that generates Go and runsgo build.It also updates verification case metadata and corpus manifest with explicit
golangskip reasons for known cross-namespace import path issues emitted byGoLangVisitor, keeping failures intentional and documented.Changes
verification/docker/golang/Dockerfileandentrypoint.sh: layers thegolang:1.25-alpinetoolchain onto the sharedconcerto-verify-baseimage, generates Go viaconcerto compile --target GoLang, fans generated files out into per-package subdirectories (Go requires one package per directory, unlike the flat output the visitor emits), and runsgo build ./...golanginscripts/verification/docker-run.jsTARGETS,.github/workflows/verify-codegen.ymlmatrix, andverification/docker/targets.jsonverify:docker:golangnpm script topackage.json, matching the existing per-target script patterntest/verification/golang.compile.test.js: generates Go from each verification case viaGoLangVisitor, mirrors the same per-package fan-out fix, writes a syntheticgo.mod, and runsgo build ./..., skipping gracefully when thegotoolchain isn't installedgolangskip reasons to all 7 cases intest/verification/cases.jsand to themetamodelcase inverification/corpus/manifest.json, documenting a pre-existingGoLangVisitorbug (bare package-name imports instead of Go module-relative import paths) that breaksgo buildfor any model with cross-namespace imports (e.g. anything referencingconcerto.decorator)Flags
GoLang(following the same convention asJavaVisitor→Java,CSharpVisitor→CSharp,RustVisitor→Rust, i.e. visitor class name minusVisitor); this should be double-checked against the installed@accordproject/concerto-cliversion if verification behaves unexpectedly.Author Checklist
--signoffoption of git commit.mainfromfork:branchname