add option to omit validation keywords#254
Open
devanshi00 wants to merge 2 commits into
Open
Conversation
Signed-off-by: “Devanshi <117909426+devanshi00@users.noreply.github.com>
DianaLease
approved these changes
Jul 10, 2026
DianaLease
approved these changes
Jul 10, 2026
DianaLease
left a comment
Member
There was a problem hiding this comment.
Looks good, but can you fix this lint errors?
/Users/runner/work/concerto-codegen/concerto-codegen/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js
Error: 406:42 error Trailing spaces not allowed no-trailing-spaces
Error: 486:54 error Trailing spaces not allowed no-trailing-spaces
Error: 622:60 error Trailing spaces not allowed no-trailing-spaces
Signed-off-by: “Devanshi <117909426+devanshi00@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #253
Changes
Added an optional
omitValidatorsparameter toJSONSchemaVisitor, defaulting tofalseto preserve existing behavior.Updated
getFieldOrScalarDeclarationValidatorsForSchema()to skip emitting validator-derived JSON Schema keywords whenomitValidatorsis enabled.Added JSDoc documentation for the new parameter and its effect on generated schemas.
Covered all validator-derived keywords emitted by the visitor, including:
patternformat(uuid,date-time)minLengthmaxLengthminimummaximumexclusiveMinimumexclusiveMaximummultipleOfFlags
Screenshots or Video
Related Issues
Author Checklist
--signoffoption of git commit.mainfromfork:branchname