Any time we use pass a callsign over http we need to encodeURIComponent()#1096
Any time we use pass a callsign over http we need to encodeURIComponent()#1096alanhargreaves wants to merge 1 commit into
Conversation
|
I'm running this locally to verify that it addresses the issue. If to this evening, I expect to see VK2IO/P activating in the morning on CW. |
|
ok it looks like |
accius
left a comment
There was a problem hiding this comment.
Correct fix. Line 280 was the only callsign-bearing fetch in this file still interpolating raw, the user-callsign spots fetch at line 244 already runs through encodeURIComponent, so this brings the location lookup in line with it. A skimmer callsign with a / portable suffix would otherwise break the path segment.
One thing: this is still marked draft. Flip it to ready when you are happy with it and it can go in.
K0CJH
|
@alanhargreaves checking in on this one — the fix itself is plainly correct (portable suffixes like Your side-observation about |
What does this PR do?
Any time we pass a callsign to the server API in
useRBN.jswe need to encode the callsign so callsigns with suffixes like/Pdon't screw things up.Type of change
How to test
Watch an RBN skimmer for a known CW op operating with a suffix like
/Pthat has also spotted in either DX Cluster or an ActivatorPanel type spot and verify that we get the proper location.Checklist
server.js: caches have TTLs and size caps (we serve 2,000+ concurrent users)var(--accent-cyan), etc.).bak,.old,console.logdebug lines, or test scripts included