ParseConstant: discover itemoptionconstant_* files instead of a hardcoded suffix list - #3
Closed
Zintixx wants to merge 2 commits into
Closed
ParseConstant: discover itemoptionconstant_* files instead of a hardcoded suffix list#3Zintixx wants to merge 2 commits into
Zintixx wants to merge 2 commits into
Conversation
…oded suffix list Enumerate all itemoption/constant/itemoptionconstant_* pack entries (matching the pattern already used by ItemParser/AchieveParser/MapParser/etc.) rather than iterating a fixed constantSuffix array. This auto-discovers any constant file (including custom merge files) with no list to maintain, and skips missing files instead of throwing on GetEntry. Removes the now-dead constantSuffix array and bumps the package to 2.4.20. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Owner
Author
|
Retargeting to MS2Community/Maple2.File (correct upstream). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ParseConstantiterated a hardcodedconstantSuffixarray to build filenames. This replaces it with a prefix scan over the archive's file list — the same idiom already used byItemParser,AchieveParser,MapParser,AdditionalEffectParser,FunctionCubeParser, etc.Why
itemoptionconstant_*file (including custom merge files) with no suffix list to maintain.GetEntry(...).First(...)when a listed suffix has no file.Removes the now-dead
constantSuffixarray.No behavioral regression: the ingest consumer keys constant options by
(code, grade)and throws on true duplicates regardless of order, so the enumeration-order change (archiveFileListorder vs the fixed array) doesn't affect correctness.Bumps
PackageVersionto 2.4.20 (2.4.19 is already published).🤖 Generated with Claude Code