Bugfix + Change to custom TripTracker in CompanyUI#305
Draft
Luc-Sol wants to merge 3 commits into
Draft
Conversation
- Fixed a bug where additional vehicles did not get the custom triptrackers because the map_createdCustomTripWeeklyConfiguration was queried with the vehicle instead of vehicleType. - To align with the engine & Java convention of weeks starting in Sunday I have changed the matrix_vehicleTripsConfigurationButtons. Note: Because the engine implementation of the ActivityTracker still has the old convention of weeks starting on mondays there is now an offset in the rows. This offset can be removed after the ActivityTracker is refactored.
added some debugging buttons/plots, must be removed before this branch is merged into main
This reverts commit 8330a6e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accompanied by changes in the engine: Zenmo/zero_engine#310