Fix modScriptPackages holding full paths instead of package names

[marlonrichert]

$this.modScriptPackages is typed [string[]], but was assigned the raw Get-ChildItem -Directory results (DirectoryInfo objects). PowerShell coerces each to its full path via ToString(), not just the folder name, so every later "$name.u" package-copy step built a garbage path. Platform-independent bug, not Linux-specific.

[robojumper]

Can you clarify whether this is specific to the cross-platform Powershell?

[marlonrichert]

It's not specific to cross-platform PowerShell. Rather, it's specific to the code in build_common.ps1 that deals with Highlander cooking.

$this.modScriptPackages is declared as [string[]] here:

X2ModBuildCommon/build_common.ps1

Line 47 in 14e97e1

[string[]] $modScriptPackages

_SetupUtils() tries to populate it here:

X2ModBuildCommon/build_common.ps1

Line 243 in 14e97e1

$this.modScriptPackages = @(Get-ChildItem "$($this.modSrcRoot)/Src" -Directory)

But @(Get-ChildItem "$($this.modSrcRoot)/Src" -Directory) does not return [string[]]; it returns [System.IO.DirectoryInfo[]].

To make the assignment work, PowerShell silently converts each DirectoryInfo to string by calling ToString() on it. However, DirectoryInfo.ToString() does not return the name of the directory; it returns the path of the directory.

This becomes a problem in _HasNativePackages() and _CopyScriptPackages(). They try to detect native packages by comparing elements from $this.modScriptPackages against the contents of $global:nativescriptpackages, but the latter does not contain paths:

X2ModBuildCommon/build_common.ps1

Line 13 in 14e97e1

$global:nativescriptpackages = @("XComGame", "Core", "Engine", "GFxUI", "AkAudio", "GameFramework", "UnrealEd", "GFxUIEditor", "IpDrv", "OnlineSubsystemPC", "OnlineSubsystemLive", "OnlineSubsystemSteamworks", "OnlineSubsystemPSN")

Thus, _HasNativePackages() always returns false, since the if in its foreach cannot succeed:

	[bool]_HasNativePackages() {
		# Check if this is a Highlander and we need to cook things
		$anynative = $false
		foreach ($name in $this.modScriptPackages) 
		{
			if ($global:nativescriptpackages.Contains($name)) {
				$anynative = $true
				break
			}
		}
		return $anynative
	}

Likewise, _CopyScriptPackages() will copy only non-native packages, because the if in its foreach cannot succeed either:

	[void]_CopyScriptPackages() {
		# copy packages to staging
		foreach ($name in $this.modScriptPackages) {
			if ($this.cookHL -and $global:nativescriptpackages.Contains($name))
			{
				# This is a native (cooked) script package -- copy important upks
				Copy-Item "$($this.cookerOutputPath)\$name.upk" "$($this.stagingPath)\CookedPCConsole" -Force -WarningAction SilentlyContinue
				Copy-Item "$($this.cookerOutputPath)\$name.upk.uncompressed_size" "$($this.stagingPath)\CookedPCConsole" -Force -WarningAction SilentlyContinue
				Write-Host "$($this.cookerOutputPath)\$name.upk"
			}
			else
			{
				# Or this is a non-native package
				Copy-Item "$($this.sdkPath)\XComGame\Script\$name.u" "$($this.stagingPath)\Script" -Force -WarningAction SilentlyContinue
				Write-Host "$($this.sdkPath)\XComGame\Script\$name.u"
			}
		}
	}

My commit fixes this by populating $this.modScriptPackages with directory names instead of paths.

[robojumper]

Right, but the Highlander X2ModBuildCommon (which has an older version) already has this line:

https://github.com/X2CommunityCore/X2WOTCCommunityHighlander/blob/1e872694b4f383d2a2232755612bc782363fec0f/.scripts/X2ModBuildCommon/build_common.ps1#L207-L209

If your explanation is right, then the current Highlander build should also be completely broken, but it isn't, at least with the classic powershell.

[marlonrichert]

OK, interesting. I'll have to investigate further.

[marlonrichert]

I need your help to resolve your question: Can you add a Write-Host before the return in _HasNativePackages() on a Windows PowerShell build and confirm whether it returns true or false?