HTML API: Clarify parse_next_attribute() return value - #13203
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
4876c30 to
0f7bacd
Compare
0f7bacd to
162c09d
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Docs-only follow-up to r62595 (#12319), which rolled back a change to the
parse_next_attribute()@returndocs so it wouldn't hold up the fix. See the review discussion: #12319 (comment)The existing line, "Whether an attribute was found before the end of the document," names only one reason for a
falsereturn. The common one is reaching the end of the tag. This keeps the positive "whether an attribute was found" framing and names both stop conditions.Trac ticket: https://core.trac.wordpress.org/ticket/65860
Follow-up to r62595 (see #65372).
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Fable 5
Used for: Drafting the
@returntext from the linked review discussion; reviewed and edited by me.This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.