Skip to content

HTML API: Clarify parse_next_attribute() return value - #13203

Open
sirreal wants to merge 1 commit into
WordPress:trunkfrom
sirreal:html-api/parse-next-attribute-docs
Open

HTML API: Clarify parse_next_attribute() return value#13203
sirreal wants to merge 1 commit into
WordPress:trunkfrom
sirreal:html-api/parse-next-attribute-docs

Conversation

@sirreal

@sirreal sirreal commented Aug 20, 2026

Copy link
Copy Markdown
Member

Docs-only follow-up to r62595 (#12319), which rolled back a change to the parse_next_attribute() @return docs so it wouldn't hold up the fix. See the review discussion: #12319 (comment)

The existing line, "Whether an attribute was found before the end of the document," names only one reason for a false return. The common one is reaching the end of the tag. This keeps the positive "whether an attribute was found" framing and names both stop conditions.

Trac ticket: https://core.trac.wordpress.org/ticket/65860

Follow-up to r62595 (see #65372).

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Fable 5
Used for: Drafting the @return text from the linked review discussion; reviewed and edited by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@sirreal
sirreal force-pushed the html-api/parse-next-attribute-docs branch from 4876c30 to 0f7bacd Compare August 20, 2026 13:04
@sirreal
sirreal force-pushed the html-api/parse-next-attribute-docs branch from 0f7bacd to 162c09d Compare August 20, 2026 13:04
@sirreal sirreal changed the title HTML API: Document parse_next_attribute() return value and end tag handling HTML API: Clarify parse_next_attribute() return value Aug 20, 2026
@sirreal
sirreal marked this pull request as ready for review August 20, 2026 13:06
@sirreal
sirreal requested a review from dmsnell August 20, 2026 13:06
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jonsurrell.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant