Skip to content

Tests: Improve isolation for randomized query tests #13188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sirreal wants to merge 2 commits into
base: trunk
Choose a base branch
from
+11 −2
Draft

Tests: Improve isolation for randomized query tests #13188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71ec9ce
Tests: Improve isolation for randomized query tests
sirreal Aug 19, 2026
b17fa59
Tests: Use a valid orderby value in WP_Query test.
sirreal Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/phpunit/includes/testcase-canonical.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ public function set_up() {
update_option( 'posts_per_page', 5 );

$this->set_permalink_structure( $this->structure );
create_initial_taxonomies();
$this->reset_taxonomies();
flush_rewrite_rules();
}

/**
Expand Down
8 changes: 8 additions & 0 deletions tests/phpunit/tests/query/stickies.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,12 @@
*/
class Tests_Query_Stickies extends WP_UnitTestCase {
public static $posts = array();
private static $original_sticky_posts;

public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
self::$original_sticky_posts = get_option( 'sticky_posts' );
update_option( 'sticky_posts', array() );

// Set post times to get a reliable order.
$now = time();
for ( $i = 0; $i <= 22; $i++ ) {
Expand All @@ -26,6 +30,10 @@ public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
stick_post( self::$posts[8] );
}

public static function wpTearDownAfterClass() {
update_option( 'sticky_posts', self::$original_sticky_posts );
}

public function test_stickies_should_be_ignored_when_is_home_is_false() {
$q = new WP_Query(
array(
Expand Down
2 changes: 1 addition & 1 deletion tests/phpunit/tests/query/thePost.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ function ( $fields, $query ) {
'fields' => 'custom',
'post_type' => 'page',
'post__in' => self::$page_child_ids,
'orderby' => 'id',
'orderby' => 'ID',
'order' => 'ASC',
)
);
Expand Down
Loading