Skip to content

Tests: Reset comment globals between tests - #13186

Draft
sirreal wants to merge 2 commits into
WordPress:trunkfrom
sirreal:agent/test-order-comment-isolation
Draft

Tests: Reset comment globals between tests#13186
sirreal wants to merge 2 commits into
WordPress:trunkfrom
sirreal:agent/test-order-comment-isolation

Conversation

@sirreal

@sirreal sirreal commented Aug 20, 2026

Copy link
Copy Markdown
Member

Summary

  • Clears the global comment fixture after author-URL-link tests.
  • Resets $in_comment_loop with the existing comment-loop globals between tests so an empty wp_list_comments() call cannot affect later permalink logic.
  • Keeps the changes confined to PHPUnit tests and fixtures.

Verification

  • Replayed the original failing seed and minimized it to the comments-template contaminator followed by the comment-link consumer.
  • 100 consecutive fresh randomized comment-group runs passed on the combined campaign branch after the final fix; each completed 627 tests and 1,530 assertions. The relevant fixture patch matches this isolated branch.
  • Seeds 1789011001 through 1789011100 all exited cleanly.
  • PHP syntax checks and git diff --check passed.

Trac: https://core.trac.wordpress.org/ticket/65893

@sirreal sirreal changed the title Tests: Reset global comment after author URL tests Tests: Reset comment globals between tests Aug 20, 2026
@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant