Skip to content

updated and added and formated .editorconfig #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rakshitgoyal770 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

updated and added and formated .editorconfig #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
root = true

[*]
indent_style = tab

@nora-weisser nora-weisser Jul 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As currently we have YAML format for template issues that would be broken by a tab-indenting editor. It must use spaces, not tabs. The [*] block sets indent_style = tab for every file, but YAML syntax forbids tab indentation. Prettier already emits spaces for YAML regardless of useTabs, so the .editorconfig should mirror that with an override.

You might consider putting it at the end:

# YAML disallows tab indentation; Prettier emits spaces here too
[*.{yml,yaml}]
indent_style = space
indent_size = 2

indent_size = 2
tab_width = 2
end_of_line = lf
charset = utf-8
insert_final_newline = true
trim_trailing_whitespace = true

@nora-weisser nora-weisser Jul 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
trim_trailing_whitespace = true
trim_trailing_whitespace = true
max_line_length = 120

It will mirror Prettier's printWidth.


[*.md]
trim_trailing_whitespace = false

@nora-weisser nora-weisser Jul 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also noticed that package-lock.json has been reformatted. It is generated and owned by npm, which always writes it as 2-space JSON, therefore should not be reformatted.
The .editorconfig should match what npm (and .prettierignore) already do. You might want to consider adding something like this:

[package-lock.json]
indent_style = space
indent_size = 2

Loading