fix: exclude 0-hour ad-hoc availability from mentor cycle list (#726, #762)

[yingliu-data]

Summary

A mentor who declared a month with 0 hours of ad-hoc availability was still surfaced in that cycle's public mentor list, because a ticked-but-zero-hour month was treated as real availability. This fixes it on both the backend (display) and the admin form (data entry).

Backend — exclude 0-hour availability from the cycle list

MenteeSection.toDtoForCycle now drops ad-hoc entries with zero (or null) hours in addition to the existing current-month filter. A mentor whose only availability for the cycle month is 0 hours no longer derives the AD_HOC type, so they are excluded from the ad-hoc mentor list. This also cleans up any existing 0-hour data.

Admin (edit-mentor form) — keep the checkbox in sync with hours

In admin-wcc-app's MentorshipAvailabilitySection:

• Typing hours > 0 auto-ticks the month; setting hours = 0 auto-unticks it.
• Unticking a month resets its hours to 0.
• transformFormData submits only months with hours > 0, so a 0-hour month is never saved as available in the first place.

Testing

• Backend: verified locally end-to-end — with the open cycle set to ad-hoc/July, a mentor set to July/0h is excluded from GET /api/cms/v1/mentorship/mentors?mentorshipTypes=AD_HOC, while a mentor with July/3h remains.
• Admin: verified the checkbox/hours sync and that a 0-hour month is not submitted; tsc, eslint, and prettier pass on the changed files.

Note: a backend regression test for the 0-hour exclusion was prepared but is not included in this PR (excluded intentionally). Happy to add it in a follow-up.

Closes

• Closes bug: Mentor with 0 available hours is included in the cycle mentor list #726 (backend: mentor with 0 available hours included in the cycle list)
• Closes bug: Admin edit-mentor form submits ad-hoc months with 0 hours (checkbox not synced to hours) #762 (admin edit-mentor form submits ad-hoc months with 0 hours)

Related (not fixed here)

Part of the broader mentor availability / admin-form and mentors-display cluster:

• fix(frontend): correct mentor edit field binding #606 — mentor edit field binding/hydration
• bug: Creating a mentor via Admin portal loses gender flag and mentorship availability (long-term / ad-hoc) details #684 — create mentor loses gender/availability
• bug: Admin portal does not let the user enter long-term availability details; saving stores a hardcoded default #688 — admin long-term availability hardcoded default
• bug: unable to update mentor with missing languages in Admin UI #720 — unable to update mentor with missing languages
• bug: Mentor's page silently returns incorrect data (empty list of mentors) if the mentor's page is missing #654 — mentors page returns empty list when the CMS page is missing

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
platform-admin	Ignored		Jul 4, 2026 12:30pm

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud