Fix fstracecheck2 so trace declarations are actually validated.#30
Open
pacujo wants to merge 1 commit into
Open
Fix fstracecheck2 so trace declarations are actually validated.#30pacujo wants to merge 1 commit into
pacujo wants to merge 1 commit into
Conversation
With plain -E preprocessing, GCC inserts #line directives inside FSTRACE_DECL expansions, splitting fstrace_specify() across several lines. The declaration regex never matches, so fstracecheck2 finds no events and silently skips validation. Preprocess with -P to suppress linemarkers, and compile checks with -Wformat -Werror like v1. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
Note: this problem was detected and fixed on a fresh Linux64 (Fedora 44). I don't know how it would behave on older Linuxes or other OS's. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With plain -E preprocessing, GCC inserts #line directives inside FSTRACE_DECL expansions, splitting fstrace_specify() across several lines. The declaration regex never matches, so fstracecheck2 finds no events and silently skips validation. Preprocess with -P to suppress linemarkers, and compile checks with -Wformat -Werror like v1.