WI01098846 - Control layout wrong#38
Merged
Merged
Conversation
wtg-mg8
reviewed
Jul 14, 2026
| <PackageVersion Condition="'$(PackageVersion)' == ''">$(WtgPackageVersionPrefix)-dev</PackageVersion> | ||
| <PackageDescription>WiseTech Global forked version of System.Windows.Forms that includes controls that were deprecated in .NET Core 3.1 and .NET 5, like DataGrid, Menu, ToolBar and StatusBar.</PackageDescription> | ||
| <PackageReleaseNotes>Rollback custom binding context support in BindingContext/RelatedCurrencyManager, PR link: https://github.com/WiseTechGlobal/winforms/pull/20</PackageReleaseNotes> | ||
| <PackageReleaseNotes>Remove IsScalingRequirementMet from DefaultLayout.cs, PR link: https://github.com/WiseTechGlobal/winforms/pull/37</PackageReleaseNotes> |
There was a problem hiding this comment.
Hi @jaywang-cn, this should read PR38:
Suggested change
| <PackageReleaseNotes>Remove IsScalingRequirementMet from DefaultLayout.cs, PR link: https://github.com/WiseTechGlobal/winforms/pull/37</PackageReleaseNotes> | |
| <PackageReleaseNotes>Remove IsScalingRequirementMet from DefaultLayout.cs, PR link: https://github.com/WiseTechGlobal/winforms/pull/38</PackageReleaseNotes> |
wtg-mg8
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WI01098846 - Control layout wrong
This PR mostly does 2 things:
Reason: There are several forms coming across the controls layout problem. One is related to the DPI and the other is related to the Anchor.
In the https://github.com/WiseTechGlobal/CargoWise.Controls.WinForms.Legacy/pull/43, it fixed the layout problem by removing the
IsScalingRequirementMetfrom theDefaultLayout, while in the be654c1, it almost address same problem based on the regression document Anchor Layout High-DPI Regression, so I think the later is not needed anymore.