Skip to content

Remove unused boost-uuid dependency - #52

Open
Vara715 wants to merge 1 commit into
WikiOpenCite:mainfrom
Vara715:remove-unused-boost-uuid
Open

Remove unused boost-uuid dependency#52
Vara715 wants to merge 1 commit into
WikiOpenCite:mainfrom
Vara715:remove-unused-boost-uuid

Conversation

@Vara715

@Vara715 Vara715 commented Jul 30, 2026

Copy link
Copy Markdown

Summary

Removes the unused boost-uuid dependency.

Changes

  • Removed boost-uuid from vcpkg.json
  • Removed uuid from the Boost components in CMakeLists.txt
  • Removed Boost::uuid from the linked libraries

I searched the source code and couldn't find any usage of boost::uuids or any Boost UUID headers, so this dependency appears to no longer be required.

@Computroniks

Copy link
Copy Markdown
Member

Hi @Vara693 , thank you for your contribution. As per the contributing guide (CONTRIBUTING.md) please can you sign off your commit. The instructions below may help:

Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using --allow-empty)

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~1 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin remove-unused-boost-uuid

@Computroniks Computroniks linked an issue Jul 30, 2026 that may be closed by this pull request
Signed-off-by: Vara693 <pvaradraj2@gmail.com>
@Vara715
Vara715 force-pushed the remove-unused-boost-uuid branch from f5f0289 to 4fb9365 Compare July 30, 2026 15:08
@Vara715

Vara715 commented Jul 30, 2026

Copy link
Copy Markdown
Author

Thanks for pointing that out! I've added the DCO sign-off and force-pushed the updated commit.

@Vara715

Vara715 commented Aug 6, 2026

Copy link
Copy Markdown
Author

Can you kindly review the request as the changes regarding the dco have long been made?

Computroniks
Computroniks previously approved these changes Aug 6, 2026
@Computroniks
Computroniks dismissed their stale review August 6, 2026 15:43

Commit requires verified signature

@Computroniks

Computroniks commented Aug 6, 2026

Copy link
Copy Markdown
Member

Hi @Vara693, thank you for making those changes. Unfortunately I have just noticed that your commit has not been signed with a verified key. This means that the commit can't be merged into the main branch due to the repositories rules. If you could possibly sign your commit that would be great.

I do apologise for this not being included in the contribution guide, it was an oversight that has been corrected.

Thank you again for your contribution.

https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Computroniks added a commit that referenced this pull request Aug 6, 2026
This was missing as a requirement and led to issues in code contributions in #52

Signed-off-by: Zoe Nickson<mjn6@st-andrews.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check if we still need boost-uuid

2 participants