Remove unused boost-uuid dependency - #52
Conversation
|
Hi @Vara693 , thank you for your contribution. As per the contributing guide (CONTRIBUTING.md) please can you sign off your commit. The instructions below may help: Rebase the branchIf you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing"). You should only do this if:
To add your Signed-off-by line to every commit in this branch:
|
Signed-off-by: Vara693 <pvaradraj2@gmail.com>
f5f0289 to
4fb9365
Compare
|
Thanks for pointing that out! I've added the DCO sign-off and force-pushed the updated commit. |
|
Can you kindly review the request as the changes regarding the dco have long been made? |
|
Hi @Vara693, thank you for making those changes. Unfortunately I have just noticed that your commit has not been signed with a verified key. This means that the commit can't be merged into the main branch due to the repositories rules. If you could possibly sign your commit that would be great. I do apologise for this not being included in the contribution guide, it was an oversight that has been corrected. Thank you again for your contribution. https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
This was missing as a requirement and led to issues in code contributions in #52 Signed-off-by: Zoe Nickson<mjn6@st-andrews.ac.uk>
Summary
Removes the unused
boost-uuiddependency.Changes
boost-uuidfromvcpkg.jsonuuidfrom the Boost components inCMakeLists.txtBoost::uuidfrom the linked librariesI searched the source code and couldn't find any usage of
boost::uuidsor any Boost UUID headers, so this dependency appears to no longer be required.