fix regex flag for python 3.11 and those higher#353
Closed
emmanuel-stone wants to merge 1 commit into
Closed
Conversation
Collaborator
|
I believe this was fixed with this PR: |
Author
|
thank you for the merging of the #313 ! thank you very much for your efforts of the maintaining - again, I am such a big fan of your repo and use it all the time when I preprocess wiki ! with warm regards, emmanuel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there, thanks for the great repo. I am an NLP researcher and I use this repo all the time for the preprocessing of wikipedia text.
For the compatibility with newer version of python, I believe this update might be an effective fix.
The issue that I had was regarding the errors such as those below.
The patch was for the regex, considering the recent recommendation on regex, regarding
(?i)patterns.I tested the patch locally for python 3.8, 3.9, 3.10, 3.11, 3.12, 3.13, and 3.14.
I hope that it would be merged but even in such a case that it would not, I hope that one or two persons would find it helpful, if they encounter the same issue.
I tag seemingly related ones: #340 #342 #343 #348