feat(toolchain): pin node version via nvm automatically#95
Merged
Conversation
WhiteMuush
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make the toolchain self-correct the Node version so a fresh machine works without manual nvm juggling.
doctor.sh: when Node is not 22 and nvm is present, report it as an auto-fixable failure that switches to Node 22 via nvm and reinstalls deps.Makefile: run all npm/npx targets throughscripts/use-node.sh, which selects the.nvmrcversion via nvm before running, somake run/make installwork even when the shell default Node is wrong.Why
On another machine the default Node was 24;
engine-strictblockednpm install(EBADENGINE), leaving node_modules incomplete and the build failing on a missing module.