fix: use cleaned name for QSettings delete and rename operations - #39
Open
CViescaA wants to merge 1 commit into
Open
fix: use cleaned name for QSettings delete and rename operations#39CViescaA wants to merge 1 commit into
CViescaA wants to merge 1 commit into
Conversation
The clean_name_for_storage() introduced in PR #27 was not applied in on_remove_server_config_clicked and checkConfigName, causing deletions and renames to fail when the stored key differs from the displayed original name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The clean_name_for_storage() introduced in PR #27 was not applied in on_remove_server_config_clicked and checkConfigName, causing deletions and renames to fail when the stored key differs from the displayed original name.