Modernize PHP/PHPUnit support and fix PHP 8 compatibility issues - #30
Merged
Conversation
Bump minimum PHP to 7.2 and PHPUnit to 8.5/9.6 so the library and its test suite actually install and run on current PHP (the old "*" phpunit constraint was resolving to PHPUnit 13, which no longer has PHPUnit_Framework_TestCase). Replace the defunct Travis CI config with a GitHub Actions matrix covering PHP 7.2-8.4. Also fix a dead-variable warning in LIVR::validate() and an unqualified `throw new Exception` in Text::like() that referenced a non-existent class under PHP 8. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
composer.lock is generated on a single PHP version and pins dependency versions (e.g. nikic/php-parser v5) that require newer PHP than some matrix jobs target, causing "lock file does not contain a compatible set of packages" on PHP 7.2/7.3. Resolving fresh per job avoids this. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump minimum PHP to 7.2 and PHPUnit to 8.5/9.6 so the library and its test suite actually install and run on current PHP (the old "*" phpunit constraint was resolving to PHPUnit 13, which no longer has PHPUnit_Framework_TestCase). Replace the defunct Travis CI config with a GitHub Actions matrix covering PHP 7.2-8.4. Also fix a dead-variable warning in LIVR::validate() and an unqualified
throw new Exceptionin Text::like() that referenced a non-existent class under PHP 8.