Implement SIP#321
Open
DPnimo11 wants to merge 24 commits into
Open
Conversation
| + np.cos(lat_1) * np.cos(lat_2) * np.sin(dlon / 2) ** 2 | ||
| ) | ||
| return 2 * _EARTH_RADIUS_M * np.arcsin(np.sqrt(a)) | ||
| return np.linalg.norm(query_coords[stop_1] - query_coords[stop_2], axis=1) |
Collaborator
There was a problem hiding this comment.
A function like this already exists in nomad/stop_detection/utils.py#L154 , something like temporal_blocking also exists, but I'm not super convinced it is necessary here.
Please integrate and avoid redundancy.
Author
There was a problem hiding this comment.
I replaced _pair_distances with _haversine_distance. For temporal blocking, it's not strictly necessary, but I feel like it is still worth including as a performance upgrade; I saw speedup on the order of 10x when I tested on 500 users.
…darren-contact-sip
…darren-contact-sip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds contact-based SIP MVP:
location_idor radius distance