fix(jsonrpc-utils): require exact loopback host for isLocalhostUrl - #281
Open
SashaMIT wants to merge 1 commit into
Open
fix(jsonrpc-utils): require exact loopback host for isLocalhostUrl#281SashaMIT wants to merge 1 commit into
SashaMIT wants to merge 1 commit into
Conversation
Unanchored wss?://localhost prefix matched wss://localhost.evil.example and disabled TLS verification in ws-connection. Parse the URL and allow only exact localhost / 127.0.0.1 / ::1 websocket hosts.
|
All contributors have signed the CTA ✍️ ✅ |
Author
|
I have read the CTA Document and I hereby sign the CTA |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isLocalhostUrlused an unanchoredwss?://localhostregex. That matchedwss://localhost.evil.example/wss://localhostfoo, andws-connectionthen setrejectUnauthorized: false.Parse with
URLand allow only exact websocket hostslocalhost,127.0.0.1, and::1/[::1].Test plan
mocha ./test/url.test.ts(3 passing)ws://localhostrelays still skip TLS verify as intendedMade with Cursor