feat: add --discord notification channel to subscription command#7
Open
Tankman61 wants to merge 2 commits into
Open
feat: add --discord notification channel to subscription command#7Tankman61 wants to merge 2 commits into
Tankman61 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
--discordflag towatcloud subscriptionso users can be notified on Discord (via a webhook URL) instead of email when a SLURM job completes.watcloud subscription <job_id> <email>— unchanged (email)watcloud subscription <job_id> --discord <webhook_url>— new (Discord)The API client now sends
{job_id, channel, target}to theslurm-status-monitor/subscribeendpoint. Pairs with the server-side support in WATonomous/infra-config#5422 (which added thechannelcolumn and Discord routing).A user creates a webhook in their own Discord channel (Edit Channel → Integrations → Webhooks → New Webhook → Copy URL) and passes it via
--discord.Tested:
go buildandgo vetclean;--discordappears insubscription --help.