Template-gate the results-table column headers for metabolomics - #224
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe change adds template-aware protein-column display handling for significant-protein and abundance tables, propagates ChangesTemplate-aware display
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@R/utils.R`:
- Around line 1147-1150: Update the conditional in
rename_protein_column_for_display to wrap the app_template() comparison with
isTRUE(), so NULL or NA values safely preserve the Protein header while the
metabolomics case still renames it to Metabolite.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 09a5ea31-0b1c-4bf9-9a48-f2a5529cf059
📒 Files selected for processing (6)
NAMESPACER/module-statmodel-server.RR/qc-server-summary.RR/statmodel-server-results-table.RR/utils.Rman/visualizeNetworkServer.Rd
Motivation and Context
Metabolomics templates require user-facing results-table headers to use “Metabolite” instead of “Protein”. The original data must remain unchanged for downstream processing and CSV downloads.
The change adds template-aware display renaming and passes the active application template to relevant table-rendering paths.
Changes
rename_protein_column_for_display()to renameProteintoMetabolitefor metabolomics templates.app_templatetorender_results_table().app_templatetorender_results_table().updateRadioButtonsfromshiny.visualizeNetworkServerdocumentation and signature to accept an optional reactiveapp_template.Tests
Coding Guidelines