feat(vpn): fail-fast reachability check + timeouts for VPN-gated targets (ADR-011) - #172
Open
vsutra-admin wants to merge 1 commit into
Open
feat(vpn): fail-fast reachability check + timeouts for VPN-gated targets (ADR-011)#172vsutra-admin wants to merge 1 commit into
vsutra-admin wants to merge 1 commit into
Conversation
…ets (ADR-011) Operators connect the VPN tunnel manually on the controller before triggering a deploy - Ansible/Jenkins never drives openconnect itself (see Virtual-Sutra/openspecimen-ansible#143). This adds the pieces that belong in the core playbook for that model: - inventory/customers/ocserv-openspecimen/hosts: ansible_timeout + ansible_become_timeout 10s -> 60s, scoped to this VPN-gated customer only (not a global ansible.cfg change - direct/EICE customers should keep failing fast on a genuinely unreachable host). The ocserv PoC found VPN tunnel latency (~200ms+) tight enough to fail privilege escalation before the connection even finished setting up. - site.yml: a new pre-flight play (vpn_required opt-in, default off) that waits for the target's SSH port before the main play's implicit fact gathering would otherwise be the first thing to hit a down tunnel, then fails with a clear "check the tunnel" message (matching verify-customer.yml's existing assert/fail_msg convention) instead of a deep, generic SSH timeout. - inventory/customers/ocserv-openspecimen/: test profile for the ocserv AnyConnect PoC target, vpn_required: true.
vsutra-admin
force-pushed
the
infra/vpn-connectivity-adr011
branch
from
August 11, 2026 07:04
68ee247 to
e1bf172
Compare
Author
🤖 Automated reviewFindings below were applied before this comment was posted (branch was amended + force-pushed). Simplify
Code review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ADR-011 VPN connectivity (Virtual-Sutra/openspecimen-ansible epic #143): operators connect the VPN tunnel manually on the controller before triggering a deploy — Ansible/Jenkins never drives
openconnect, computes a TOTP code, or stores a VPN credential. This PR adds the pieces of that model that belong in the core playbook:ansible.cfg: SSH +privilege_escalationtimeout10s → 60s. TheocservAnyConnect PoC (PR fix(tomcat): adopt a legacy unmarked datasource block in shared context.xml #149 inopenspecimen-ansible) found VPN tunnel round-trip latency (~200ms+) tight enough to fail privilege escalation before the connection even finished setting up — harmless for fast/direct connections, which never come close to the limit.site.yml: a new pre-flight play, gated on an opt-invpn_requiredcustomer var (default off), that waits for the target's SSH port before the main play's implicit fact-gathering would otherwise be the first thing to hit a down tunnel — turns a deep, generic SSH timeout into a clear "check the tunnel" failure instead.inventory/customers/ocserv-openspecimen/: test customer profile for theocservAnyConnect PoC target,vpn_required: true.No Jenkinsfile changes, no new credentials, no
openconnect/TOTP automation anywhere in this repo — that's intentionally out of scope.Related: Virtual-Sutra/openspecimen-ansible#143
Test plan
ansible-playbook site.yml --syntax-check -i inventory/customers/ocserv-openspecimen/ocserv-openspecimen, pre-flight check passes; negative test with the tunnel disconnected produces the pre-flight failure instead of a deep SSH timeout